----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37821/#review97789 -----------------------------------------------------------
Ship it! Looks good. Just a few little nits. 3rdparty/libprocess/src/event_loop.hpp (lines 45 - 46) <https://reviews.apache.org/r/37821/#comment153812> This fits in one line. 3rdparty/libprocess/src/process.cpp (line 436) <https://reviews.apache.org/r/37821/#comment153814> Missing period at the end. 3rdparty/libprocess/src/process.cpp (lines 442 - 443) <https://reviews.apache.org/r/37821/#comment153815> Fits on one line, but I think this should be fine (77 characters). 3rdparty/libprocess/src/process.cpp (lines 2144 - 2146) <https://reviews.apache.org/r/37821/#comment153804> Can you update this comment to note that the actual "popping" of the process is done in `ProcessManager::cleanup`, which can happen as a result of `Process::terminate`? 3rdparty/libprocess/src/process.cpp (line 2178) <https://reviews.apache.org/r/37821/#comment153816> I think you should tweak this to use backticks instead of single quotes, even if it's a copy-pasted comment. 3rdparty/libprocess/src/process.cpp (lines 2191 - 2192) <https://reviews.apache.org/r/37821/#comment153818> Also fits on one line (73 characters). 3rdparty/libprocess/src/process.cpp (lines 2193 - 2194) <https://reviews.apache.org/r/37821/#comment153819> Could you change the spacing to: ``` threads.emplace_back( new std::thread(&internal::schedule, std::cref(joining_threads))); ``` (I vaguely remember that this was the preference over vertically aligning arguments.) - Joseph Wu On Sept. 4, 2015, 11:13 a.m., Greg Mann wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/37821/ > ----------------------------------------------------------- > > (Updated Sept. 4, 2015, 11:13 a.m.) > > > Review request for mesos, Benjamin Hindman, Artem Harutyunyan, Joris Van > Remoortere, Joseph Wu, and switched to 'mcypark'. > > > Bugs: MESOS-3158 > https://issues.apache.org/jira/browse/MESOS-3158 > > > Repository: mesos > > > Description > ------- > > Join threads in libprocess when shutting down. > > > Diffs > ----- > > 3rdparty/libprocess/src/event_loop.hpp > 36a4cd2b1ff59f6922173ad17115bf80cc3c8f30 > 3rdparty/libprocess/src/libev.cpp 97a2694f9b10bc61841443b21f4f96055493e840 > 3rdparty/libprocess/src/libevent.cpp > ee7906470069b0391dde7cd685b1d4eb3a158c03 > 3rdparty/libprocess/src/process.cpp > 755187c8761137cb2bf2f7295b29a63f63c68bc6 > > Diff: https://reviews.apache.org/r/37821/diff/ > > > Testing > ------- > > After configuring with both "../configure" and "../configure > --enable-libevent --enable-ssl": > > make check > > > Also, to check for race conditions related to the initialization/shutdown of > libprocess, try something like: > > for n in {1..1000}; do echo $n; 3rdparty/libprocess/tests > --gtest_filter=ProcessTest.Spawn; done > > > Thanks, > > Greg Mann > >