> On Aug. 31, 2015, 6:50 p.m., Joseph Wu wrote:
> > cmake/MesosConfigure.cmake, line 125
> > <https://reviews.apache.org/r/37275/diff/2/?file=1036055#file1036055line125>
> >
> >     Why do you need this?  (If you do need it, comment why.)
> >     
> >     It doesn't look like the inputs have any semicolons.

Because cmake convert list [a, b, c] to string "a;b;c". When we write a string 
to file, need replace ";" to " " first.


- haosdent


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37275/#review97113
-----------------------------------------------------------


On Sept. 4, 2015, 4:24 a.m., haosdent huang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37275/
> -----------------------------------------------------------
> 
> (Updated Sept. 4, 2015, 4:24 a.m.)
> 
> 
> Review request for mesos, Artem Harutyunyan, Alex Clemmer, and Joseph Wu.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Generate make batch file to build project in windows.
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt 3b6f4af337466d33cb915959a5995e4307b27be3 
>   cmake/MesosConfigure.cmake b530da4c1e6f202b682ad7d6892da95d2181f8c8 
> 
> Diff: https://reviews.apache.org/r/37275/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> haosdent huang
> 
>

Reply via email to