----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38117/#review97870 -----------------------------------------------------------
src/slave/containerizer/isolators/network/port_mapping.cpp (line 1148) <https://reviews.apache.org/r/38117/#comment153931> A bit duplicate code here, is it possible to determine which hashmap should use, and then fill it? - haosdent huang On Sept. 4, 2015, 1:17 a.m., Cong Wang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/38117/ > ----------------------------------------------------------- > > (Updated Sept. 4, 2015, 1:17 a.m.) > > > Review request for mesos, Jie Yu, Paul Brett, and Vinod Kone. > > > Bugs: MESOS-3365 > https://issues.apache.org/jira/browse/MESOS-3365 > > > Repository: mesos > > > Description > ------- > > These stats are those we get by `netstat -s`, they are important for diagnose > networking issues. > > > Diffs > ----- > > include/mesos/mesos.proto b1deed4720cab4a89db76a48bc9563bba4f5bf1c > src/slave/containerizer/isolators/network/port_mapping.hpp > 4bca0b81bf69fb4cd75e05aacd02d3e818e32d09 > src/slave/containerizer/isolators/network/port_mapping.cpp > 34ba2294b0bd7d57aa9de073692a2ea8ec62681d > src/slave/flags.hpp b8335aa585376d27b71897f8cbaefaa12f4b3a5c > src/slave/flags.cpp 49fb0007356eedf7095d34a1312e99bafa8fdc4d > > Diff: https://reviews.apache.org/r/38117/diff/ > > > Testing > ------- > > Manual tests > > > Thanks, > > Cong Wang > >