----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38154/#review98067 -----------------------------------------------------------
Ship it! One minor nit. 3rdparty/libprocess/3rdparty/stout/include/stout/protobuf.hpp (lines 557 - 558) <https://reviews.apache.org/r/38154/#comment154290> I think this comment isn't really necessary. You could remove it. And the comment adds a bit of ambiguity (i.e. what's different about `is_convertible` that `is_public_base_of` provides?) - Joseph Wu On Sept. 7, 2015, 4:24 a.m., Alexander Rukletsov wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/38154/ > ----------------------------------------------------------- > > (Updated Sept. 7, 2015, 4:24 a.m.) > > > Review request for mesos and Michael Park. > > > Bugs: MESOS-3312 > https://issues.apache.org/jira/browse/MESOS-3312 > > > Repository: mesos > > > Description > ------- > > See summary. > > > Diffs > ----- > > 3rdparty/libprocess/3rdparty/stout/include/stout/protobuf.hpp > 57d5fdf45273c620655b44b5f5572290cffa4bf6 > > Diff: https://reviews.apache.org/r/38154/diff/ > > > Testing > ------- > > make check (Mac OS 10.10.4) > > > Thanks, > > Alexander Rukletsov > >
