> On Sept. 9, 2015, 5:16 p.m., Joris Van Remoortere wrote: > > 3rdparty/libprocess/src/process.cpp, lines 757-773 > > <https://reviews.apache.org/r/37877/diff/1/?file=1057703#file1057703line757> > > > > Would you agree that what is happening here is not immediately obvious? > > > > Now that you understand it, would you mind adding a few comments around > > the different exit conditions and which stage of intitialization they > > represent? > > > > In particular I think the exit condition around 769 could use a comment.
"Not immediately obvious" is an understatement :) I can certainly add comments, although I wonder whether this logic can't be rethought and simplified; if we need to keep the existing logic, seems we should point out the assignment to "initializing" down below. I'll take a look at this, but can we do it as a separate review? - Neil ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37877/#review98207 ----------------------------------------------------------- On Sept. 9, 2015, 4:01 p.m., Neil Conway wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/37877/ > ----------------------------------------------------------- > > (Updated Sept. 9, 2015, 4:01 p.m.) > > > Review request for mesos, Joris Van Remoortere and switched to 'mcypark'. > > > Bugs: MESOS-3326 > https://issues.apache.org/jira/browse/MESOS-3326 > > > Repository: mesos > > > Description > ------- > > MESOS-3326. > > > Diffs > ----- > > 3rdparty/libprocess/include/process/latch.hpp > a1a2227a9edcc31fd82c6410262aa4565fd66cb2 > 3rdparty/libprocess/include/process/metrics/counter.hpp > e51a8beb80b15dd64aa2e481036ae8ba37125640 > 3rdparty/libprocess/include/process/process.hpp > 009f7c4167fa379ac6b1c267e1b4d5fcdf28d697 > 3rdparty/libprocess/src/clock.cpp 09c60e5a5d9bd9fc5511e57f3209fad7dbf834d6 > 3rdparty/libprocess/src/latch.cpp f7d94d92e85c58878d98e13757b6fc37837ca977 > 3rdparty/libprocess/src/process.cpp > 755187c8761137cb2bf2f7295b29a63f63c68bc6 > 3rdparty/libprocess/src/process_reference.hpp > f8df4a6dcf01bb7af750c1ed9e85c64cea2042c5 > > Diff: https://reviews.apache.org/r/37877/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Neil Conway > >
