> On Sept. 1, 2015, 9:35 p.m., Timothy Chen wrote: > > src/slave/containerizer/provisioners/docker/registry_client.cpp, line 359 > > <https://reviews.apache.org/r/37773/diff/9/?file=1060828#file1060828line359> > > > > Should we make sure somewhere that we encode or check the tag so that > > we don't contain spaces? > > Jojy Varghese wrote: > I am not sure if http path can contain spaces. Queries can. > > Timothy Chen wrote: > Therefore we shouldn't allow it right?
Ok will add validation. Although this validation belongs in the URL class. - Jojy ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37773/#review97331 ----------------------------------------------------------- On Sept. 9, 2015, 4:50 p.m., Jojy Varghese wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/37773/ > ----------------------------------------------------------- > > (Updated Sept. 9, 2015, 4:50 p.m.) > > > Review request for mesos, Lily Chen, Joris Van Remoortere, and Timothy Chen. > > > Repository: mesos > > > Description > ------- > > Added implementation for docker registry's Get Manifest and Get Blob APIs. > > > Diffs > ----- > > src/Makefile.am 0a8ef6d8551cf177cb565b2a443c05e8eea5ab1c > src/slave/containerizer/provisioners/docker/registry_client.hpp > PRE-CREATION > src/slave/containerizer/provisioners/docker/registry_client.cpp > PRE-CREATION > src/tests/provisioners/docker_provisioner_tests.cpp PRE-CREATION > > Diff: https://reviews.apache.org/r/37773/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Jojy Varghese > >
