----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37127/#review98355 -----------------------------------------------------------
src/master/master.cpp (line 2707) <https://reviews.apache.org/r/37127/#comment154774> Both reserve and unreserve using same exception, it is better adding operations to message to differentitate reserve and unreserve. - Guangya Liu On 八月 5, 2015, 11:17 a.m., Michael Park wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/37127/ > ----------------------------------------------------------- > > (Updated 八月 5, 2015, 11:17 a.m.) > > > Review request for mesos, Adam B and Jie Yu. > > > Bugs: MESOS-3062 > https://issues.apache.org/jira/browse/MESOS-3062 > > > Repository: mesos > > > Description > ------- > > See summary. > > > Diffs > ----- > > src/master/master.cpp 5aa0a5410804fe16abd50b6953f1ffe46a019ecf > src/tests/reservation_tests.cpp aeee36752573e3f401d3dca7d2d69c90d0e8bd6b > > Diff: https://reviews.apache.org/r/37127/diff/ > > > Testing > ------- > > Added tests to `src/tests/reservation_tests.cpp` + `make check` > > > Thanks, > > Michael Park > >