----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38253/ -----------------------------------------------------------
Review request for mesos. Bugs: MESOS-2875 https://issues.apache.org/jira/browse/MESOS-2875 Repository: mesos Description ------- We should ensure that we are addressing the container which the QoS controller intended to kill. Without this check, we may run into a scenario where the executor has terminated and one with the same id has started in the interim i.e. running in a different container than the one the QoS controller targeted. This most likely requires us to add containerId to the ResourceUsage message and encode the containerID in the QoS Correction message. Diffs ----- include/mesos/mesos.proto b1deed4720cab4a89db76a48bc9563bba4f5bf1c include/mesos/slave/oversubscription.proto fa69a95689c8c75765f0800692655e8dde7dde33 src/slave/slave.cpp 5e5522e1254a5ed6084de36782753f9aad2894c4 src/tests/oversubscription_tests.cpp 0c5edafc139d9bfb6806d007a0af85e80893bb1a Diff: https://reviews.apache.org/r/38253/diff/ Testing ------- make make check Thanks, Klaus Ma