----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37502/#review98670 -----------------------------------------------------------
3rdparty/libprocess/3rdparty/CMakeLists.txt (line 166) <https://reviews.apache.org/r/37502/#comment155204> So, what's the rationale for using `${CMAKE_CXX_FLAGS}` here? It seems to me that we only want the flags that GTest and GMock need. Is that right? What am I missing? Additionally, do we wonly want to set `GTEST_LANG_CXX11` in the case that we're compiling on Clang? If so, why? - Alex Clemmer On Sept. 4, 2015, 4:25 a.m., haosdent huang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/37502/ > ----------------------------------------------------------- > > (Updated Sept. 4, 2015, 4:25 a.m.) > > > Review request for mesos, Artem Harutyunyan, Alex Clemmer, and Joseph Wu. > > > Bugs: MESOS-3270 > https://issues.apache.org/jira/browse/MESOS-3270 > > > Repository: mesos > > > Description > ------- > > Add CMAKE_CXX_FLAGS to GMOCK_CONFIG_CMD in CMake. > > > Diffs > ----- > > 3rdparty/libprocess/3rdparty/CMakeLists.txt > 997cc0d0e316e316136d4746e50e9e292a82b36b > > Diff: https://reviews.apache.org/r/37502/diff/ > > > Testing > ------- > > > Thanks, > > haosdent huang > >
