----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38319/#review98700 -----------------------------------------------------------
Ship it! src/slave/containerizer/provisioners/appc/provisioner.cpp (lines 373 - 374) <https://reviews.apache.org/r/38319/#comment155254> string containerDir = provisioners::paths::getContainerDir(root, containerId); src/slave/containerizer/provisioners/appc/provisioner.cpp (line 375) <https://reviews.apache.org/r/38319/#comment155253> Insert a blank line above this line. - Jie Yu On Sept. 11, 2015, 9:20 p.m., Jiang Yan Xu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/38319/ > ----------------------------------------------------------- > > (Updated Sept. 11, 2015, 9:20 p.m.) > > > Review request for mesos, Jie Yu and Timothy Chen. > > > Bugs: MESOS-3415 > https://issues.apache.org/jira/browse/MESOS-3415 > > > Repository: mesos > > > Description > ------- > > - Also changed the semantics of Provisioner::create() to fail with it fails > to clean up unknown orphan containers. > > > Diffs > ----- > > src/slave/containerizer/provisioners/appc/provisioner.cpp > e177e3c2569c681a5fb8729bdb68e071b4e62ef1 > src/slave/containerizer/provisioners/paths.hpp > a2490885f28cf54a14b6de800700360b31827d88 > src/slave/containerizer/provisioners/paths.cpp > 267912cfa0699167d204e6ade158e1523fcfd7a2 > src/tests/containerizer/appc_provisioner_tests.cpp > 73c32c199804c5d2c48939ffd5d4885e4edf0fe8 > > Diff: https://reviews.apache.org/r/38319/diff/ > > > Testing > ------- > > make check. > > Added a few checks in tests for this change. > > > Thanks, > > Jiang Yan Xu > >
