> On Sept. 12, 2015, 6:38 a.m., Timothy Chen wrote: > > src/slave/containerizer/isolators/filesystem/linux.cpp, line 91 > > <https://reviews.apache.org/r/38329/diff/1/?file=1069300#file1069300line91> > > > > Should we check we did successfully found one that we can mark shared? > > Jie Yu wrote: > Good catch! Yeah, let me at that check!
In fact, that should be a CHECK because we should always find one. - Jie ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38329/#review98735 ----------------------------------------------------------- On Sept. 12, 2015, 6:36 a.m., Jie Yu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/38329/ > ----------------------------------------------------------- > > (Updated Sept. 12, 2015, 6:36 a.m.) > > > Review request for mesos, haosdent huang, Timothy Chen, Vinod Kone, and Jiang > Yan Xu. > > > Bugs: MESOS-3349 > https://issues.apache.org/jira/browse/MESOS-3349 > > > Repository: mesos > > > Description > ------- > > Ensured that the device containing slave work_dir is a shared mount when > LinuxFilesystemIsolator is used. > > See the discussion thread in the ticket for motivation (also the NOTE in the > code). > > > Diffs > ----- > > src/slave/containerizer/isolators/filesystem/linux.cpp > 0970b3d48b13d5e9d2e0160df5cf14a3dcd0acc9 > > Diff: https://reviews.apache.org/r/38329/diff/ > > > Testing > ------- > > sudo make check on CentOS5 and CentOS6 > > > Thanks, > > Jie Yu > >
