----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38279/#review98886 -----------------------------------------------------------
src/hook/manager.cpp (line 261) <https://reviews.apache.org/r/38279/#comment155558> Please also add a test that verifies that the hooks are executed in the expected order. For example, have two hooks that both modify the `cpus` resource and verify that the second value is indeed retained. - Connor Doyle On Sept. 14, 2015, 5:39 p.m., Felix Abecassis wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/38279/ > ----------------------------------------------------------- > > (Updated Sept. 14, 2015, 5:39 p.m.) > > > Review request for mesos, Connor Doyle and Niklas Nielsen. > > > Bugs: MESOS-3366 > https://issues.apache.org/jira/browse/MESOS-3366 > > > Repository: mesos > > > Description > ------- > > First API draft for MESOS-3366. > > 1) Only supports resources for now, we can add another hook for attributes > with a very similar code. > 2) The callback currently receives the full SlaveInfo structure and construct > a new Resources object. > 3) If there is multiple callbacks, each callback will see the changes made by > previous callbacks and are free to override or merge the detected resources > as they see fit. > > > Diffs > ----- > > include/mesos/hook.hpp d90bacc > src/examples/test_hook_module.cpp bc13a8a > src/hook/manager.hpp 30d8321 > src/hook/manager.cpp 754c238 > src/slave/slave.cpp 5e5522e > > Diff: https://reviews.apache.org/r/38279/diff/ > > > Testing > ------- > > make clean && make && make check > > > Thanks, > > Felix Abecassis > >
