-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38368/#review98928
-----------------------------------------------------------



src/examples/test_hook_module.cpp (line 197)
<https://reviews.apache.org/r/38368/#comment155657>

    Mind throwing in a comment about this test step?



src/examples/test_hook_module.cpp (line 198)
<https://reviews.apache.org/r/38368/#comment155664>

    How about setting the protocol (for testing)? So maybe have two network 
infos (one with each)?



src/slave/slave.cpp (lines 2757 - 2765)
<https://reviews.apache.org/r/38368/#comment155661>

    Can we either add a warning if anything else is changed (probably hard) or 
at least throw in a comment, that we only apply changes from container status 
and labels?



src/tests/hook_tests.cpp (line 513)
<https://reviews.apache.org/r/38368/#comment155663>

    Mind preceeding this test code blob with a comment about the setup?


- Niklas Nielsen


On Sept. 14, 2015, 1:55 p.m., Kapil Arya wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38368/
> -----------------------------------------------------------
> 
> (Updated Sept. 14, 2015, 1:55 p.m.)
> 
> 
> Review request for mesos, Connor Doyle, Jie Yu, and Niklas Nielsen.
> 
> 
> Bugs: MESOS-3013
>     https://issues.apache.org/jira/browse/MESOS-3013
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This allows the hook to not only update TaskStatus::labels, but also
> TaskStatus::container_status.
> 
> Enhanced example hook module and relevant test to reflect the change.
> 
> 
> Diffs
> -----
> 
>   include/mesos/hook.hpp d90baccba4ac73eb777c8848e40ba737e756032f 
>   src/examples/test_hook_module.cpp bc13a8ad0308668f31310b3aa65243bfb41b87b5 
>   src/hook/manager.hpp 30d8321f459cacdfc0397ab7cd4e81710655351a 
>   src/hook/manager.cpp 754c238fcf728d6aa5b897ed5d9f46c251345334 
>   src/slave/slave.cpp 5e5522e1254a5ed6084de36782753f9aad2894c4 
>   src/tests/common/http_tests.cpp bf8712b11339b409514ab86c1f32eaf7e9c9a2f1 
>   src/tests/hook_tests.cpp deb4343089a30073e8f1f811731b075f7d968846 
> 
> Diff: https://reviews.apache.org/r/38368/diff/
> 
> 
> Testing
> -------
> 
> make check.
> 
> 
> Thanks,
> 
> Kapil Arya
> 
>

Reply via email to