> On Sept. 14, 2015, 11:21 p.m., Cong Wang wrote:
> > Not sure how much value this patch has, because upper layer always calls it 
> > with non-empty cgroups. Also, you probably want to check for events.empty() 
> > too while you are on it.

This was done for https://reviews.apache.org/r/38380/, which removes the 
special case logic for empty set.


- Ben


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38379/#review98945
-----------------------------------------------------------


On Sept. 14, 2015, 10:57 p.m., Ben Mahler wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38379/
> -----------------------------------------------------------
> 
> (Updated Sept. 14, 2015, 10:57 p.m.)
> 
> 
> Review request for mesos and Jie Yu.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Handle empty set of cgroups as a no-op in perf::sample.
> 
> 
> Diffs
> -----
> 
>   src/linux/perf.cpp 0011482cf9d920485728798518d32af0e9627724 
>   src/tests/containerizer/perf_tests.cpp 
> bef475e4b573f02b69f2c4dd6d1c6a6e10f34c38 
> 
> Diff: https://reviews.apache.org/r/38379/diff/
> 
> 
> Testing
> -------
> 
> Added a test.
> 
> 
> Thanks,
> 
> Ben Mahler
> 
>

Reply via email to