----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38380/#review98962 -----------------------------------------------------------
src/slave/containerizer/isolators/cgroups/perf_event.cpp (line 374) <https://reviews.apache.org/r/38380/#comment155718> I don't think cgroup can be destroyed while perf running, kernel should return EBUSY, no? src/slave/containerizer/isolators/cgroups/perf_event.cpp (line 423) <https://reviews.apache.org/r/38380/#comment155719> Just nit: the original comment is useful for understanding the code, event after this change. - Cong Wang On Sept. 14, 2015, 10:57 p.m., Ben Mahler wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/38380/ > ----------------------------------------------------------- > > (Updated Sept. 14, 2015, 10:57 p.m.) > > > Review request for mesos and Jie Yu. > > > Repository: mesos > > > Description > ------- > > This removes the special casing of the empty set of cgroups case to simplify > the sample loop, along with some other minor cleanups. > > > Diffs > ----- > > src/slave/containerizer/isolators/cgroups/perf_event.cpp > 7dc8b7a99074b74ade019ef4df296780650a2e4e > > Diff: https://reviews.apache.org/r/38380/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Ben Mahler > >
