-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38408/#review99065
-----------------------------------------------------------



src/slave/containerizer/provisioner/paths.hpp (line 32)
<https://reviews.apache.org/r/38408/#comment155897>

    `provisoiners -> provisioner`: This is fine with me.



src/slave/paths.cpp (line 378)
<https://reviews.apache.org/r/38408/#comment155896>

    I don't think this needs to be changed to singular and the convention is 
that the plural form ("slaves", "frameworks", "executors", "provisioners", 
"volumes", etc.) is used for folders that serve as "container folders".


- Jiang Yan Xu


On Sept. 15, 2015, 11:51 a.m., Jie Yu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38408/
> -----------------------------------------------------------
> 
> (Updated Sept. 15, 2015, 11:51 a.m.)
> 
> 
> Review request for mesos, Timothy Chen and Jiang Yan Xu.
> 
> 
> Bugs: MESOS-3432
>     https://issues.apache.org/jira/browse/MESOS-3432
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Renamed provisioners::path to provisioner::path.
> 
> 
> Diffs
> -----
> 
>   src/slave/containerizer/provisioner/appc/provisioner.cpp 
> 77f9cbe778785bd93c30eba5dfd7a470d9258661 
>   src/slave/containerizer/provisioner/paths.hpp 
> 5b82591fbe0d1ea48e4b09727424d0547f21adc2 
>   src/slave/containerizer/provisioner/paths.cpp 
> 4293dd2fe62bd6aee9243717916c86ff9e39d9ce 
>   src/slave/paths.hpp 43c65af03a6af8d3d2d50f7c8366d7fbd26cb990 
>   src/slave/paths.cpp f104ecdbbb78093ccb968c0a01ea0924bfa391c5 
>   src/tests/paths_tests.cpp 1ccc5c70b06f44f54d843d6ed92e9105eda40a7b 
> 
> Diff: https://reviews.apache.org/r/38408/diff/
> 
> 
> Testing
> -------
> 
> sudo make check
> 
> 
> Thanks,
> 
> Jie Yu
> 
>

Reply via email to