> On Sept. 14, 2015, 6:32 p.m., Niklas Nielsen wrote: > > src/tests/containerizer/isolator_tests.cpp, line 507 > > <https://reviews.apache.org/r/38363/diff/1/?file=1073022#file1073022line507> > > > > Have you verified the status (non-error) of namespaces() before you get > > here?
The Isolator::namespace() call simply returns an Option and so the future is always satisfied and so we don't check the status here. Further, this logic gets replaced by https://reviews.apache.org/r/38365 when we remove Isolator::prepare in lieu of Isolator::prepare returning namespaces. Dropping the issue. > On Sept. 14, 2015, 6:32 p.m., Niklas Nielsen wrote: > > src/tests/containerizer/isolator_tests.cpp, line 202 > > <https://reviews.apache.org/r/38363/diff/1/?file=1073022#file1073022line202> > > > > Does it make sense to have None() as the default value? It's a pure virtual function, so we can't really have defaults AFAIK :-/. - Kapil ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38363/#review98934 ----------------------------------------------------------- On Sept. 14, 2015, 4:55 p.m., Kapil Arya wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/38363/ > ----------------------------------------------------------- > > (Updated Sept. 14, 2015, 4:55 p.m.) > > > Review request for mesos, Connor Doyle, Jie Yu, and Niklas Nielsen. > > > Bugs: MESOS-3387 > https://issues.apache.org/jira/browse/MESOS-3387 > > > Repository: mesos > > > Description > ------- > > This prepares MesosContainerizer to allow isolators to specify namespaces for > each individual containerizer. Thus, allowing isolators to decide whether or > not > to enable isolation for a particular container. > > > Diffs > ----- > > src/slave/containerizer/launcher.hpp > 8cc832e99838683c14d8158bdf52a267299508c7 > src/slave/containerizer/launcher.cpp > 5267eecbdf31c88cd3c7dc7172b5aff7bac534b0 > src/slave/containerizer/linux_launcher.hpp > bf6bf3f27dac007429c224d4f6798ac68316accb > src/slave/containerizer/linux_launcher.cpp > 12acf4d08cb7fb1161820cf4bb480fd1bc2c6858 > src/slave/containerizer/mesos/containerizer.cpp > 1b83a8725b35435531038e37188b4c97189cef03 > src/tests/containerizer/filesystem_isolator_tests.cpp > ffa371fab69ce5eebe3b02afc2a1724a0f52110f > src/tests/containerizer/isolator_tests.cpp > d34c82a7f24da6f60cfb22790f516dc6065b1f6f > src/tests/containerizer/launcher.hpp > 6f020f94b042eef0e6a69ba8c26dfb697f3e81a3 > > Diff: https://reviews.apache.org/r/38363/diff/ > > > Testing > ------- > > make check. > > > Thanks, > > Kapil Arya > >
