> On Sept. 14, 2015, 6:07 p.m., Niklas Nielsen wrote: > > include/mesos/slave/oversubscription.proto, lines 46-47 > > <https://reviews.apache.org/r/38253/diff/1/?file=1067132#file1067132line46> > > > > We need to add a comment about the semantics of executor_id vs > > container_id. For example, what happens if both is set? Or do they need to > > be set together? (Loooks like it from the code below)
Addressed; add comments that executor id must be set if kill specified container. > On Sept. 14, 2015, 6:07 p.m., Niklas Nielsen wrote: > > src/slave/slave.cpp, lines 4367-4368 > > <https://reviews.apache.org/r/38253/diff/1/?file=1067133#file1067133line4367> > > > > Style nit: > > > > ``` > > const ContainerID& containerId = > > kill.has_container_id() ? kill.container_id() : > > executor->containerId; > > ``` > > > > Also, what happens if the container id is wrong? Think we need to do > > some validation here. Addressed; if containerId was wrong, log warn message and ignore the kill request. > On Sept. 14, 2015, 6:07 p.m., Niklas Nielsen wrote: > > src/tests/oversubscription_tests.cpp, line 859 > > <https://reviews.apache.org/r/38253/diff/1/?file=1067134#file1067134line859> > > > > Mind adding a TODO about doing a full blown object comparison? Do you mean full comparison on metrics? - Klaus ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38253/#review98880 ----------------------------------------------------------- On Sept. 15, 2015, 1:08 p.m., Klaus Ma wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/38253/ > ----------------------------------------------------------- > > (Updated Sept. 15, 2015, 1:08 p.m.) > > > Review request for mesos and Niklas Nielsen. > > > Bugs: MESOS-2875 > https://issues.apache.org/jira/browse/MESOS-2875 > > > Repository: mesos > > > Description > ------- > > We should ensure that we are addressing the container which the QoS > controller intended to kill. Without this check, we may run into a scenario > where the executor has terminated and one with the same id has started in the > interim i.e. running in a different container than the one the QoS controller > targeted. > > This most likely requires us to add containerId to the ResourceUsage message > and encode the containerID in the QoS Correction message. > > > Diffs > ----- > > include/mesos/mesos.proto b1deed4 > include/mesos/slave/oversubscription.proto fa69a95 > src/slave/slave.cpp 44865bd > src/tests/oversubscription_tests.cpp 0c5edaf > > Diff: https://reviews.apache.org/r/38253/diff/ > > > Testing > ------- > > make > make check > > > Thanks, > > Klaus Ma > >
