----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38444/#review99348 -----------------------------------------------------------
Ship it! src/slave/containerizer/isolators/filesystem/linux.cpp (line 750) <https://reviews.apache.org/r/38444/#comment156240> This condition being false is actually rare and only happens when people have upgraded from a version of linux filesystem isolation from "head" or when the host mount table has been tampered with. Worth a log line? - Jiang Yan Xu On Sept. 16, 2015, 5:52 p.m., Jie Yu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/38444/ > ----------------------------------------------------------- > > (Updated Sept. 16, 2015, 5:52 p.m.) > > > Review request for mesos, Jojy Varghese, Timothy Chen, and Jiang Yan Xu. > > > Repository: mesos > > > Description > ------- > > Only unmount sandbox if the mount exists in LinuxFilesystemIsolator. > > This is for upgrade concern. Containers created by the old agent do not have > sandbox mounts. > > > Diffs > ----- > > src/slave/containerizer/isolators/filesystem/linux.cpp > 297a296d536fc72dc8ce9687c381cd666d8cadd2 > > Diff: https://reviews.apache.org/r/38444/diff/ > > > Testing > ------- > > sudo make check > > > Thanks, > > Jie Yu > >
