-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38077/#review99433
-----------------------------------------------------------


Patch looks great!

Reviews applied: [38028, 38030, 38031, 38076, 38077]

All tests passed.

- Mesos ReviewBot


On Sept. 17, 2015, 7:14 p.m., Joseph Wu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38077/
> -----------------------------------------------------------
> 
> (Updated Sept. 17, 2015, 7:14 p.m.)
> 
> 
> Review request for mesos, Ben Mahler, Artem Harutyunyan, Joris Van 
> Remoortere, Timothy Chen, and Vinod Kone.
> 
> 
> Bugs: MESOS-3345
>     https://issues.apache.org/jira/browse/MESOS-3345
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> * Add TODO's for refactoring some JSON parsing in the docker code (See 
> MESOS-3409).  Update how the JSON::Number is used.
> * Tweak some tests to match changes to JSON::Number.
> * Address a TODO on one test, which used a workaround for double-precision 
> comparison.
> 
> 
> Diffs
> -----
> 
>   src/docker/docker.cpp c4c37cb98ef50beeae0030ac472c7bf77e10fb5e 
>   src/slave/containerizer/provisioner/docker/token_manager.cpp 
> cf52626554f5bddcbbac4d515d7dd599d269dd57 
>   src/tests/fault_tolerance_tests.cpp 
> 061e0998239f7b69d989523e341881cd4abfcdeb 
>   src/tests/master_tests.cpp dd65fccf89566b367fd0da781a60b6b6b35e5d5b 
>   src/tests/monitor_tests.cpp f4049553d9f2b0e6419d9e6f88d3b0a54184f88d 
>   src/tests/rate_limiting_tests.cpp f3aeddee00c7bb7905092aa8a760603468063126 
>   src/tests/slave_tests.cpp 4a1a586f645424e30a4e989d1fd2f0bc2993b188 
> 
> Diff: https://reviews.apache.org/r/38077/diff/
> 
> 
> Testing
> -------
> 
> `make check` (OSX | clang-6.1.0, CentOS 7.1 | g++ 4.8.3)
> 
> 
> Thanks,
> 
> Joseph Wu
> 
>

Reply via email to