----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38102/#review99481 -----------------------------------------------------------
Ship it! Thanks for your patience! 3rdparty/libprocess/3rdparty/stout/include/stout/uuid.hpp (line 33) <https://reviews.apache.org/r/38102/#comment156359> Typically we name types with a capital in the first letter, like 'Generator', but let's just remove the typedef here, it doesn't seem to be helping a lot? - Ben Mahler On Sept. 15, 2015, 9:39 a.m., Klaus Ma wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/38102/ > ----------------------------------------------------------- > > (Updated Sept. 15, 2015, 9:39 a.m.) > > > Review request for mesos and Ben Mahler. > > > Bugs: MESOS-3046 > https://issues.apache.org/jira/browse/MESOS-3046 > > > Repository: mesos > > > Description > ------- > > __Phenomenon:__ > Performance downgrade > > __Root Cause:__ > stout's UUID abstraction is re-seeding the random generator during each call > to UUID::random(), which is really expensive. > > __Solution:__ > Seeding the random generator only once per thread. > > > Diffs > ----- > > 3rdparty/libprocess/3rdparty/stout/include/stout/uuid.hpp e90dabb > > Diff: https://reviews.apache.org/r/38102/diff/ > > > Testing > ------- > > make > make check > > > Thanks, > > Klaus Ma > >
