----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38470/#review99587 -----------------------------------------------------------
Ship it! Fixed before committing. src/tests/master_maintenance_tests.cpp (lines 1019 - 1023) <https://reviews.apache.org/r/38470/#comment156521> We can overload `CreateMasterFlags()` to turn this off in our tests. This will be applicable in the other tests as well. src/tests/master_maintenance_tests.cpp (line 1031) <https://reviews.apache.org/r/38470/#comment156522> ``DRAINING`` src/tests/master_maintenance_tests.cpp (lines 1214 - 1252) <https://reviews.apache.org/r/38470/#comment156525> As discussed offline, ;et's leave this part out for now. The complication is that we send out inverse offers to any framework that has: (1) tasks running (2) reserved resources (3) offered resources - Joris Van Remoortere On Sept. 18, 2015, 8:29 p.m., Joseph Wu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/38470/ > ----------------------------------------------------------- > > (Updated Sept. 18, 2015, 8:29 p.m.) > > > Review request for mesos, Benjamin Hindman, Artem Harutyunyan, and Joris Van > Remoortere. > > > Bugs: MESOS-3458 > https://issues.apache.org/jira/browse/MESOS-3458 > > > Repository: mesos > > > Description > ------- > > Add regression test. Note that the test may be slow until inverse offers > filters are actually implemented. > > > Diffs > ----- > > src/master/master.cpp 1c4e7af7448c05f54c1068d6496ed21c8c359ac5 > src/tests/master_maintenance_tests.cpp > 44785057f129a3e6a69f399f7d6db59d9d5c2e91 > > Diff: https://reviews.apache.org/r/38470/diff/ > > > Testing > ------- > > `make check` > > > Thanks, > > Joseph Wu > >
