----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38259/ -----------------------------------------------------------
(Updated Sept. 19, 2015, 12:51 a.m.) Review request for mesos, Bernd Mathiske, Marco Massenzio, and Michael Park. Changes ------- Address comments Bugs: MESOS-3340 https://issues.apache.org/jira/browse/MESOS-3340 Repository: mesos Description ------- Currently, it appears that re-defining a flag on the command-line that was already defined via a OS Env var (MESOS_*) causes the Master to fail with a not very helpful message. For example, if one has MESOS_QUORUM defined, this happens: $ ./mesos-master --zk=zk://192.168.1.4/mesos --quorum=1 --hostname=192.168.1.4 --ip=192.168.1.4 Duplicate flag 'quorum' on command line which is not very helpful. Current solution is to throw error if any duplication; over-write may make user confused about the result. Diffs (updated) ----- 3rdparty/libprocess/3rdparty/stout/include/stout/flags/flags.hpp 9da213f 3rdparty/libprocess/3rdparty/stout/tests/flags_tests.cpp 43c09f3 Diff: https://reviews.apache.org/r/38259/diff/ Testing ------- make make check Thanks, Klaus Ma