-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38517/#review99652
-----------------------------------------------------------


Patch looks great!

Reviews applied: [38517]

All tests passed.

- Mesos ReviewBot


On Sept. 19, 2015, 12:59 a.m., Felix Abecassis wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38517/
> -----------------------------------------------------------
> 
> (Updated Sept. 19, 2015, 12:59 a.m.)
> 
> 
> Review request for mesos, Connor Doyle and Niklas Nielsen.
> 
> 
> Bugs: MESOS-3366
>     https://issues.apache.org/jira/browse/MESOS-3366
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This is required in order to enable callback hooks that can modify attributes 
> of a slave during initialization.
> 
> 
> Diffs
> -----
> 
>   include/mesos/attributes.hpp PRE-CREATION 
>   src/Makefile.am 834f69a 
>   src/common/attributes.hpp 2a7efbd 
>   src/common/attributes.cpp f713bb5 
>   src/common/http.hpp 058baa6 
>   src/common/http.cpp aaef10b 
>   src/common/type_utils.cpp 22118b4 
>   src/master/http.cpp 8bde4c7 
>   src/slave/http.cpp 101aa06 
>   src/slave/slave.hpp 32e1830 
>   src/tests/attributes_tests.cpp ded6120 
>   src/tests/registrar_tests.cpp aa49c86 
> 
> Diff: https://reviews.apache.org/r/38517/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Felix Abecassis
> 
>

Reply via email to