----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37993/#review99723 -----------------------------------------------------------
Bad patch! Reviews applied: [37993] Failed command: ./support/apply-review.sh -n -r 37993 Error: 2015-09-21 05:27:48 URL:https://reviews.apache.org/r/37993/diff/raw/ [92103/92103] -> "37993.patch" [1] error: patch failed: 3rdparty/libprocess/3rdparty/CMakeLists.txt:35 error: 3rdparty/libprocess/3rdparty/CMakeLists.txt: patch does not apply error: patch failed: include/mesos/master/allocator.hpp:159 error: include/mesos/master/allocator.hpp: patch does not apply error: patch failed: src/master/master.cpp:785 error: src/master/master.cpp: patch does not apply error: patch failed: src/tests/master_maintenance_tests.cpp:1026 error: src/tests/master_maintenance_tests.cpp: patch does not apply Failed to apply patch - Mesos ReviewBot On Sept. 21, 2015, 5:02 a.m., Guangya Liu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/37993/ > ----------------------------------------------------------- > > (Updated Sept. 21, 2015, 5:02 a.m.) > > > Review request for mesos, Adam B, Alexander Rukletsov, and Michael Park. > > > Bugs: MESOS-2224 > https://issues.apache.org/jira/browse/MESOS-2224 > > > Repository: mesos > > > Description > ------- > > Add explanatory comments for Allocator interface > > > Diffs > ----- > > 3rdparty/libprocess/3rdparty/CMakeLists.txt > c746ba51c9985365428e3caaae1327a4f9bfd7d3 > 3rdparty/libprocess/3rdparty/Makefile.am > e64e3d9e958fab3c7c25fad17dcc2b279d255500 > 3rdparty/libprocess/3rdparty/picojson-1.3.0.tar.gz > 0ade1be899f63a8749e06344f2b30b960648d05e > 3rdparty/libprocess/3rdparty/picojson-4f93734.tar.gz PRE-CREATION > 3rdparty/libprocess/3rdparty/stout/include/stout/json.hpp > e36f4b9aed50a75767d29306cb8d4974c4995156 > 3rdparty/libprocess/3rdparty/stout/include/stout/protobuf.hpp > 2285ce9eaba668d5215c108849055fe92163da4d > 3rdparty/libprocess/3rdparty/stout/include/stout/uuid.hpp > bc167f1fa9e64f89138f131e726e7733c66da29c > 3rdparty/libprocess/3rdparty/stout/tests/json_tests.cpp > 88b6147fa47ebfcb6000de5b2f0891d4438d26bf > 3rdparty/libprocess/3rdparty/stout/tests/protobuf_tests.cpp > 6f154cd5ab12e1d1dd64e56574d2186ae53ee66e > 3rdparty/libprocess/3rdparty/versions.am > 98195b8eb60b2673d610d8ab7ea31103f137debf > 3rdparty/libprocess/Makefile.am c764717d447da39f78a9c74a756e611b63a814e1 > 3rdparty/libprocess/src/tests/metrics_tests.cpp > 8f15ee7e89e5346d306df71eb06a7161da13af48 > docs/mesos-c++-style-guide.md 570ea6873ffc2cc8ec190ec3aa81986e3f3cbc95 > include/mesos/master/allocator.hpp fb09e2a6502bc8c78ddcc8a595bcd9320da136ea > include/mesos/mesos.proto 4a16be1f570769f3ce42a50a9da9f4fb1c227999 > include/mesos/v1/mesos.proto 58e5a6b7912d6f96d495a34d0913b9d27ad65fb5 > src/Makefile.am 834f69afe87a093c6d275916f7781d470535a728 > src/common/protobuf_utils.hpp 3817c6a3374b2e8f333784261a0c8edabf854fd9 > src/common/protobuf_utils.cpp 4dc58fed315d99fd9cdde49e91eab1f4947ef046 > src/docker/docker.cpp afcedf1f1a309bd0626c33ee25694ac1b43bdec7 > src/master/http.cpp 8bb59355e3852617faccad8cc65e1f9dbd7988b4 > src/master/maintenance.hpp a37412ff928b0313752ca45364c0ac9e14a0f70c > src/master/maintenance.cpp 5fe935886a029c7959e07b82ec20cb31b0e7055c > src/master/master.cpp ca4d5876dcd427964111428edc22d567ddaede0b > src/slave/containerizer/provisioner/docker/token_manager.cpp > 18b29c3d0ddf25fd3f4713c5de10aeec3b381df0 > src/tests/fault_tolerance_tests.cpp > c97bc4691f9bac4a8677e6d2247be96ee9674b57 > src/tests/hierarchical_allocator_tests.cpp > 505b9de3d8d888c296f6103c80fe9f0ef1c2ca16 > src/tests/master_maintenance_tests.cpp > 9892bc329ff850f638e9f5e79d047efaf2fcb037 > src/tests/master_tests.cpp a477794df37c658b80d79dea8555b001415f7b6a > src/tests/monitor_tests.cpp 583e71183e7bc80608047bd8c323170ebfd95646 > src/tests/rate_limiting_tests.cpp e512aa690413ee871b56011a9bb1292fa8ab8c33 > src/tests/registrar_tests.cpp 5131b570e1b94431dfaea74d5f504a29e520b1f1 > src/tests/slave_tests.cpp dccdbb0ec5352df5da63d5ef7261bfc7fd599acb > > Diff: https://reviews.apache.org/r/37993/diff/ > > > Testing > ------- > > > Thanks, > > Guangya Liu > >