> On Sept. 21, 2015, 6:13 p.m., Joseph Wu wrote:
> > 3rdparty/cmake/Versions.cmake, lines 4-8
> > <https://reviews.apache.org/r/38541/diff/1/?file=1077778#file1077778line4>
> >
> >     This matches the order from `versions.am`, but you could alphabetize.

Now that you point it out, we _should_ alphabetize! It doesn't really matter 
what our style is in `versions.am`, because this isn't autoconf! :)


- Alex


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38541/#review99795
-----------------------------------------------------------


On Sept. 21, 2015, 3:23 a.m., Alex Clemmer wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38541/
> -----------------------------------------------------------
> 
> (Updated Sept. 21, 2015, 3:23 a.m.)
> 
> 
> Review request for mesos, Artem Harutyunyan, Joris Van Remoortere, and Joseph 
> Wu.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> As we prepare to add more third-party dependencies, it will be helpful
> to have all the version information of our third-party dependencies in
> one place, rather than scattered everywhere in the project.
> 
> This commit will introduce `Versions.cmake`, which will hold all this
> information.
> 
> 
> Diffs
> -----
> 
>   3rdparty/cmake/Versions.cmake PRE-CREATION 
>   CMakeLists.txt 3b6f4af337466d33cb915959a5995e4307b27be3 
> 
> Diff: https://reviews.apache.org/r/38541/diff/
> 
> 
> Testing
> -------
> 
> Compiled and ran made sure libprocess and stout tests ran and passed on the 
> following platforms:
> 
> * OS X 10.10
> * Windows 10
> * Ubuntu 14.04.2
> 
> 
> Thanks,
> 
> Alex Clemmer
> 
>

Reply via email to