----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38577/#review99886 -----------------------------------------------------------
LGTM, thanks for working on this Isabel ! Waiting for some unit-tests to bless/approve the implementation code before giving this a Ship It. src/slave/validation.hpp (line 18) <https://reviews.apache.org/r/38577/#comment156900> Missing header include guards ? src/slave/validation.hpp (line 28) <https://reviews.apache.org/r/38577/#comment156902> newline before. I am expecting other people to add slave validation code in this file too in the future. So separating `namespace executor/call` by a newline would be a good idea. src/slave/validation.hpp (line 32) <https://reviews.apache.org/r/38577/#comment156903> What do you think about going ahead and implementing some unit tests ? You can create another patch if you would like for the tests. But in general, it's good practice to have tests in most cases even for this trivial validation code :) I guess we would need the following tests in `src/tests/executor_http_api_tests.cpp` ? - Missing Executor/Framework Id. - Invalid call message that is not initialized. - Invalid call message that does not have Subscribe/Update/Message but has the corresponding type set. src/slave/validation.cpp (line 25) <https://reviews.apache.org/r/38577/#comment156905> newline before. Same reason as before. - Anand Mazumdar On Sept. 21, 2015, 11:23 p.m., Isabel Jimenez wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/38577/ > ----------------------------------------------------------- > > (Updated Sept. 21, 2015, 11:23 p.m.) > > > Review request for mesos, Anand Mazumdar, Ben Mahler, and Vinod Kone. > > > Bugs: MESOS-2906 > https://issues.apache.org/jira/browse/MESOS-2906 > > > Repository: mesos > > > Description > ------- > > Added validation for Call protobuf message in Agent /api/v1/executor endpoint. > > > Diffs > ----- > > src/Makefile.am e224060 > src/slave/http.cpp 12a4d39 > src/slave/validation.hpp PRE-CREATION > src/slave/validation.cpp PRE-CREATION > > Diff: https://reviews.apache.org/r/38577/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Isabel Jimenez > >
