> On Sept. 22, 2015, 1:33 a.m., Kapil Arya wrote: > > src/tests/hook_tests.cpp, line 695 > > <https://reviews.apache.org/r/38279/diff/2/?file=1077263#file1077263line695> > > > > Is it worth checking that resources indeed contains a "foo" before > > validating the value of "foo"?
Not sure what you mean, do you want to add another assertion? If there is no "foo" here, won't the test fail cleanly anyway? - Felix ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38279/#review99892 ----------------------------------------------------------- On Sept. 22, 2015, 1:26 a.m., Felix Abecassis wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/38279/ > ----------------------------------------------------------- > > (Updated Sept. 22, 2015, 1:26 a.m.) > > > Review request for mesos, Connor Doyle and Niklas Nielsen. > > > Bugs: MESOS-3366 > https://issues.apache.org/jira/browse/MESOS-3366 > > > Repository: mesos > > > Description > ------- > > First API draft for MESOS-3366. > > 1) Only supports resources for now, we can add another hook for attributes > with a very similar code. > 2) The callback currently receives the full SlaveInfo structure and construct > a new Resources object. > 3) If there is multiple callbacks, each callback will see the changes made by > previous callbacks and are free to override or merge the detected resources > as they see fit. > > > Diffs > ----- > > include/mesos/hook.hpp 2353602 > src/examples/test_hook_module.cpp 0dc74d6 > src/hook/manager.hpp a517c05 > src/hook/manager.cpp 691976e > src/slave/slave.cpp 29865ec > src/tests/hook_tests.cpp b23a587 > > Diff: https://reviews.apache.org/r/38279/diff/ > > > Testing > ------- > > make clean && make && make check > > > Thanks, > > Felix Abecassis > >
