-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38634/#review100111
-----------------------------------------------------------


A few questions below


src/slave/containerizer/linux_launcher.cpp (line 122)
<https://reviews.apache.org/r/38634/#comment157226>

    Can you use stat()/lstat() instead? Shelling and grepping seems a bit scary



src/slave/containerizer/linux_launcher.cpp (line 138)
<https://reviews.apache.org/r/38634/#comment157227>

    Full path to command and subprocess (or other execvp alternative)?



src/slave/containerizer/linux_launcher.cpp (line 165)
<https://reviews.apache.org/r/38634/#comment157229>

    Move constant this to a const at the top?
    Also, want to refer to a JIRA issue tracking this?


- Niklas Nielsen


On Sept. 22, 2015, 10:29 a.m., Joris Van Remoortere wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38634/
> -----------------------------------------------------------
> 
> (Updated Sept. 22, 2015, 10:29 a.m.)
> 
> 
> Review request for mesos, Benjamin Hindman, Artem Harutyunyan, Jie Yu, Niklas 
> Nielsen, Thomas Rampelberg, and Timothy Chen.
> 
> 
> Bugs: MESOS-3425
>     https://issues.apache.org/jira/browse/MESOS-3425
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This will be used to perform Systemd specific actions.
> 
> 
> Diffs
> -----
> 
>   src/slave/containerizer/linux_launcher.hpp 
> f6112c98ffcc46ebcaf5581e821d5481d2f6b494 
>   src/slave/containerizer/linux_launcher.cpp 
> fd0ffcf838a745ccd458d57821d358eceb85be26 
> 
> Diff: https://reviews.apache.org/r/38634/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Joris Van Remoortere
> 
>

Reply via email to