> On Sept. 18, 2015, 12:59 a.m., Joseph Wu wrote: > > docs/authentication.md, line 14 > > <https://reviews.apache.org/r/38399/diff/3/?file=1075888#file1075888line14> > > > > Are you sure this is correct? The ACL changes shouldn't change > > authentication, only authorization.
This is used for authentication, the ACL principal should be authenticated before authorization. > On Sept. 18, 2015, 12:59 a.m., Joseph Wu wrote: > > src/master/http.cpp, lines 1473-1504 > > <https://reviews.apache.org/r/38399/diff/3/?file=1075895#file1075895line1473> > > > > Can you refactor this into a helper function? No reason to copy-paste > > it three times. Will add a helper funtion in next patchset. Thanks. > On Sept. 18, 2015, 12:59 a.m., Joseph Wu wrote: > > src/master/master.hpp, lines 934-947 > > <https://reviews.apache.org/r/38399/diff/3/?file=1075896#file1075896line934> > > > > We strongly prefer the other pattern of continuation. See the note > > above. Will consider it, thanks. - Zhiwei ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38399/#review99402 ----------------------------------------------------------- On Sept. 23, 2015, 1:16 p.m., Zhiwei Chen wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/38399/ > ----------------------------------------------------------- > > (Updated Sept. 23, 2015, 1:16 p.m.) > > > Review request for mesos, Alexander Rojas, Artem Harutyunyan, Joris Van > Remoortere, Joseph Wu, and Till Toenshoff. > > > Bugs: mesos-2222 > https://issues.apache.org/jira/browse/mesos-2222 > > > Repository: mesos > > > Description > ------- > > Add ACLs for the maintenance HTTP endpoints > > The design doc: > https://docs.google.com/document/d/1sG28ASH-5MDygR2igackOb5x-Lt5nXyIUMcwrrbk4cE/edit?usp=sharing > > > Diffs > ----- > > docs/authentication.md 1c22c5416caf66b28238fc181a255e51ed16d867 > docs/authorization.md 2a5e74782754e446184a297f91112e9f94077896 > include/mesos/authorizer/authorizer.hpp > d667a52f90f970a313580446a5a006cec4b5e25b > include/mesos/authorizer/authorizer.proto > 86bbb45f9d91b4098a262e3e50a793f3bb39497e > src/authorizer/local/authorizer.hpp > 32de102fd588f029882ef2222121ca83a7410c65 > src/authorizer/local/authorizer.cpp > 6d7da87731a438c2180cf91003e09d4aa5a1c773 > src/master/flags.cpp 80879611fbcfd764c9fc8f60a31613a9c8fc2364 > src/master/http.cpp f7ce9aa56b453c1d37b99dd836d956ab292ab62e > src/master/master.hpp d48ef7c0da8978a5e02e69e055ff010585b20ceb > src/tests/master_maintenance_tests.cpp > 44785057f129a3e6a69f399f7d6db59d9d5c2e91 > src/tests/mesos.hpp 3db97aca921c9216d90384e1eb17030849516454 > > Diff: https://reviews.apache.org/r/38399/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Zhiwei Chen > >
