-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38158/#review100239
-----------------------------------------------------------

Ship it!


I've submitted this review request with the following minor changes, and 
removed some of the `std::` qualifications which were unnecessary.


src/common/values.cpp (line 23)
<https://reviews.apache.org/r/38158/#comment157404>

    Removed `<iostream>`, `<set>`
    Added `<initializer_list>`, `<ostream>`, `<string>` `<tuple>`, `<utility>`.



src/common/values.cpp (line 110)
<https://reviews.apache.org/r/38158/#comment157403>

    `{` on a newline.



src/common/values.cpp (line 120)
<https://reviews.apache.org/r/38158/#comment157405>

    Renamed `lhs`, `rhs` to `left`, `right`.



src/common/values.cpp (lines 162 - 163)
<https://reviews.apache.org/r/38158/#comment157400>

    ```
    result->mutable_range()->DeleteSubrange(
        count, result->range_size() - count);
    ```



src/common/values.cpp (line 188)
<https://reviews.apache.org/r/38158/#comment157401>

    ```
    void coalesce(
        Value::Ranges* result,
        std::initializer_list<Value::Ranges> addedRanges)
    {
    ```



src/common/values.cpp (line 221)
<https://reviews.apache.org/r/38158/#comment157402>

    (1) `{` on the newline.
    (2) Renamed `lhs`, `rhs` to `result`, `addedRange`


- Michael Park


On Sept. 23, 2015, 12:37 p.m., Joerg Schad wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38158/
> -----------------------------------------------------------
> 
> (Updated Sept. 23, 2015, 12:37 p.m.)
> 
> 
> Review request for mesos, Bernd Mathiske, Joris Van Remoortere, and Till 
> Toenshoff.
> 
> 
> Bugs: MESOS-3051
>     https://issues.apache.org/jira/browse/MESOS-3051
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> The goal of this refactoring was to reuse the Ranges objects as much as 
> possible, as prior there was substantial time spend in allocation/destruction 
> (MESOS-3051).
> 
> 
> Diffs
> -----
> 
>   src/common/values.cpp 750264e603b4cde2011f07f4434a4b34fe3e512f 
>   src/tests/resources_tests.cpp 0318885336409f7cc9dbd4a3daa9b52db197bbd1 
>   src/tests/values_tests.cpp fc35d97894a2de6207b9337180e2160e6f2cb1f5 
> 
> Diff: https://reviews.apache.org/r/38158/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Joerg Schad
> 
>

Reply via email to