----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38699/#review100329 -----------------------------------------------------------
3rdparty/libprocess/3rdparty/stout/include/stout/os/posix/fork.hpp (line 266) <https://reviews.apache.org/r/38699/#comment157513> Is it possible for the shared memory deleter to execute in the forked context? Or are we guaranteed that the last reference is in the parent? If not, this change seems problematic since close is not async signal safe (Try uses new which uses malloc). It looks like ABORT with std::string is also problematic in the error case. - Ben Mahler On Sept. 24, 2015, 12:21 a.m., Chi Zhang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/38699/ > ----------------------------------------------------------- > > (Updated Sept. 24, 2015, 12:21 a.m.) > > > Review request for mesos and Vinod Kone. > > > Bugs: mesos-2768 > https://issues.apache.org/jira/browse/mesos-2768 > > > Repository: mesos > > > Description > ------- > > stout: use os::close everywhere. > > > Diffs > ----- > > 3rdparty/libprocess/3rdparty/stout/include/stout/os/posix/fork.hpp > 7eb51e8771e95f57548fc35753e75c6d56cd97cd > > Diff: https://reviews.apache.org/r/38699/diff/ > > > Testing > ------- > > > Thanks, > > Chi Zhang > >
