----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38637/#review100335 -----------------------------------------------------------
Ship it! Agree with Jie on returning 'Failure' instead of 'EXIT'. Great! src/slave/containerizer/linux_launcher.cpp (line 176) <https://reviews.apache.org/r/38637/#comment157523> See previous review regarding renaming this. - Benjamin Hindman On Sept. 23, 2015, 8:34 p.m., Joris Van Remoortere wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/38637/ > ----------------------------------------------------------- > > (Updated Sept. 23, 2015, 8:34 p.m.) > > > Review request for mesos, Benjamin Hindman, Artem Harutyunyan, Jie Yu, Niklas > Nielsen, Thomas Rampelberg, and Timothy Chen. > > > Bugs: MESOS-3425 > https://issues.apache.org/jira/browse/MESOS-3425 > > > Repository: mesos > > > Description > ------- > > See summary. > > > Diffs > ----- > > src/slave/containerizer/linux_launcher.cpp > 459af1b98ba577863d88d521f3ba8792959f42b4 > > Diff: https://reviews.apache.org/r/38637/diff/ > > > Testing > ------- > > make check > on ubuntu 15.04 with systemd 219 verified that pids get assigned to the > `mesos_executor.slice`, and operator is warned about lack of proper resource > isolation upon recovery if the executor pid is no longer in the slice. > > > Thanks, > > Joris Van Remoortere > >
