-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38454/#review100354
-----------------------------------------------------------


Patch looks great!

Reviews applied: [38454]

All tests passed.

- Mesos ReviewBot


On Sept. 24, 2015, 1:55 a.m., Jian Qiu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38454/
> -----------------------------------------------------------
> 
> (Updated Sept. 24, 2015, 1:55 a.m.)
> 
> 
> Review request for mesos, haosdent huang, Marco Massenzio, and Vinod Kone.
> 
> 
> Bugs: MESOS-3293
>     https://issues.apache.org/jira/browse/MESOS-3293
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This test is to isolate one single process with one thread in cgroup, and 
> checks the number of processes and threads in the cgroup before/after 
> isolation. The previous test case uses "sh -c "while true; do sleep 1; 
> done;"" as the process, however, it periodically forks a child process "sleep 
> 1" in cgroup causing the test failure (expected number of process/thread 
> should be 1, but here is 2). This patch is to issue a "cat" command, so there 
> will be only one process in cgroup.
> 
> 
> Diffs
> -----
> 
>   src/tests/containerizer/isolator_tests.cpp 
> a25ae97a519feb8ead6177da160df8a276ca15bf 
> 
> Diff: https://reviews.apache.org/r/38454/diff/
> 
> 
> Testing
> -------
> 
> ./mesos-tests.sh 
> --gtest_filter="LimitedCpuIsolatorTest.ROOT_CGROUPS_Pids_and_Tids" 
> --gtest_repeat=1000 --gtest_break_on_failure
> 
> 
> Thanks,
> 
> Jian Qiu
> 
>

Reply via email to