----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38727/#review100457 -----------------------------------------------------------
Patch looks great! Reviews applied: [38726, 38727] All tests passed. - Mesos ReviewBot On Sept. 24, 2015, 6:53 p.m., Joris Van Remoortere wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/38727/ > ----------------------------------------------------------- > > (Updated Sept. 24, 2015, 6:53 p.m.) > > > Review request for mesos and Benjamin Hindman. > > > Bugs: MESOS-3510 > https://issues.apache.org/jira/browse/MESOS-3510 > > > Repository: mesos > > > Description > ------- > > This aids in verifying the files are kept in sync. > diff src/common/values.cpp src/v1/values.cpp should result > in only include and namespace differences. > > > Diffs > ----- > > src/v1/values.cpp aaa9a7e19e70634890ff38aefa9817ed68682697 > > Diff: https://reviews.apache.org/r/38727/diff/ > > > Testing > ------- > > diff src/common/values.cpp src/v1/values.cpp > ``` > 33,34c33,34 > < #include <mesos/resources.hpp> > < #include <mesos/values.hpp> > --- > > #include <mesos/v1/resources.hpp> > > #include <mesos/v1/values.hpp> > 46a47 > > namespace v1 { > 95d95 > < > 638a639 > > } // namespace v1 { > ``` > > > Thanks, > > Joris Van Remoortere > >
