-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38731/#review100474
-----------------------------------------------------------


Patch looks great!

Reviews applied: [38726, 38727, 38731]

All tests passed.

- Mesos ReviewBot


On Sept. 24, 2015, 8:20 p.m., Joris Van Remoortere wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38731/
> -----------------------------------------------------------
> 
> (Updated Sept. 24, 2015, 8:20 p.m.)
> 
> 
> Review request for mesos and Benjamin Hindman.
> 
> 
> Bugs: MESOS-3510
>     https://issues.apache.org/jira/browse/MESOS-3510
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This aids in verifying the files are kept in sync.
> diff src/common/resources.cpp src/v1/resources.cpp should result
> in only include and namespace differences.
> 
> 
> Diffs
> -----
> 
>   src/common/resources.cpp abfc6f34cd444cab7c95c2706a408ec9d3a66025 
>   src/v1/resources.cpp dc868903472f8f3a1ddc56092e3f8f81d953ce39 
> 
> Diff: https://reviews.apache.org/r/38731/diff/
> 
> 
> Testing
> -------
> 
> diff src/common/resources.cpp src/v1/resources.cpp
> ```
> 27,29c27,29
> < #include <mesos/resources.hpp>
> < #include <mesos/values.hpp>
> < #include <mesos/type_utils.hpp>
> ---
> > #include <mesos/v1/mesos.hpp>
> > #include <mesos/v1/resources.hpp>
> > #include <mesos/v1/values.hpp>
> 43a44
> > namespace v1 {
> 1263a1265
> > } // namespace v1 {
> ```
> 
> 
> Thanks,
> 
> Joris Van Remoortere
> 
>

Reply via email to