-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38733/#review100495
-----------------------------------------------------------

Ship it!


But let's keep the 'checkpoint' stuff in type_utils.cpp for now just to be 
conservative.

- Benjamin Hindman


On Sept. 24, 2015, 9:24 p.m., Joris Van Remoortere wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38733/
> -----------------------------------------------------------
> 
> (Updated Sept. 24, 2015, 9:24 p.m.)
> 
> 
> Review request for mesos and Benjamin Hindman.
> 
> 
> Bugs: MESOS-3510
>     https://issues.apache.org/jira/browse/MESOS-3510
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This aids in verifying the files are kept in sync.
> diff src/common/type_utils.cpp src/v1/mesos.cpp should result
> in only include and namespace differences.
> 
> Moved some things out of type_utils.cpp that are not part of the
> public API. They were moved into messages.cpp.
> 
> 
> Diffs
> -----
> 
>   include/mesos/type_utils.hpp 6cedf079c710c7d6ab8f95c47c133e6a1efe9a82 
>   include/mesos/v1/mesos.hpp 260e1125dea792ebcece404f94363e8c4bc36f28 
>   src/Makefile.am 776483bfe54255eb44dffed9fb43f3b26235fb40 
>   src/common/type_utils.cpp 5f74daba208bf22f1ab159a8e0c920e14c7a4614 
>   src/messages/messages.cpp PRE-CREATION 
>   src/v1/mesos.cpp 631d6e5290b27b6fcb8cbe56378dad620e55fbbf 
> 
> Diff: https://reviews.apache.org/r/38733/diff/
> 
> 
> Testing
> -------
> 
> diff src/common/type_utils.cpp src/v1/mesos.cpp
> ```
> 19,24c19,21
> < #include <mesos/attributes.hpp>
> < #include <mesos/mesos.hpp>
> < #include <mesos/resources.hpp>
> < #include <mesos/type_utils.hpp>
> < 
> < #include "messages/messages.hpp"
> ---
> > #include <mesos/v1/attributes.hpp>
> > #include <mesos/v1/mesos.hpp>
> > #include <mesos/v1/resources.hpp>
> 26a24
> > namespace v1 {
> 331c329
> < bool operator==(const SlaveInfo& left, const SlaveInfo& right)
> ---
> > bool operator==(const AgentInfo& left, const AgentInfo& right)
> 348c346
> <     left.slave_id() == right.slave_id() &&
> ---
> >     left.agent_id() == right.agent_id() &&
> 362a361,362
> > 
> > } // namespace v1 {
> ```
> 
> 
> Thanks,
> 
> Joris Van Remoortere
> 
>

Reply via email to