> On Sept. 25, 2015, 6:05 p.m., Artem Harutyunyan wrote: > > cmake/CompilationConfigure.cmake, line 84 > > <https://reviews.apache.org/r/38755/diff/1/?file=1084612#file1084612line84> > > > > NOLINT?
Doesn't complain on my box, I don't think it's necessary. Also, this _does_ run when you commit normally, right? (_i.e._ not during a rebase) - Alex ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38755/#review100637 ----------------------------------------------------------- On Sept. 25, 2015, 10:13 p.m., Alex Clemmer wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/38755/ > ----------------------------------------------------------- > > (Updated Sept. 25, 2015, 10:13 p.m.) > > > Review request for mesos, Artem Harutyunyan, Joris Van Remoortere, and Joseph > Wu. > > > Repository: mesos > > > Description > ------- > > CMake: Move compiler configuration logic to its own file. > > > Diffs > ----- > > cmake/CompilationConfigure.cmake PRE-CREATION > cmake/MesosConfigure.cmake b530da4c1e6f202b682ad7d6892da95d2181f8c8 > > Diff: https://reviews.apache.org/r/38755/diff/ > > > Testing > ------- > > Compiled and ran made sure libprocess and stout tests ran and passed on the > following platforms: > > * OS X 10.10 > * Ubuntu 14.04.2 > > > Thanks, > > Alex Clemmer > >
