> On Sept. 23, 2015, 9:10 p.m., Vinod Kone wrote:
> > 3rdparty/libprocess/src/decoder.hpp, line 157
> > <https://reviews.apache.org/r/38597/diff/1/?file=1079711#file1079711line157>
> >
> >     not needed anymore?

Yes not needed, not totally obvious but if you look at the ifdef'ed 
`HTTP_PARSER_VERSION_MAJOR` code, the url parts either come in:

(1) From separate callbacks: `on_path`, `on_query_string`, `on_fragment`, or:
(2) From the `on_url` callback, and we use `http_parser_parse_url` to parse the 
path, query, fragment.


> On Sept. 23, 2015, 9:10 p.m., Vinod Kone wrote:
> > 3rdparty/libprocess/include/process/http.hpp, line 180
> > <https://reviews.apache.org/r/38597/diff/1/?file=1079709#file1079709line180>
> >
> >     s/a//

Thanks!


- Ben


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38597/#review100281
-----------------------------------------------------------


On Sept. 22, 2015, 6:18 a.m., Ben Mahler wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38597/
> -----------------------------------------------------------
> 
> (Updated Sept. 22, 2015, 6:18 a.m.)
> 
> 
> Review request for mesos, Benjamin Hindman, Jie Yu, and Vinod Kone.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Now that URL is a URI-reference, we can implement the TODO to replace the raw 
> fields in Request with a URL.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/include/process/firewall.hpp 
> b1abfb29fe2db07d991e9a6f655345720faef863 
>   3rdparty/libprocess/include/process/http.hpp 
> fbd6cf7967173495875a8ea90ed28ade88b982a2 
>   3rdparty/libprocess/include/process/system.hpp 
> 264d948c2c000c6cb176601735bd4ea0d6fcbc77 
>   3rdparty/libprocess/src/decoder.hpp 
> 67a5135f302153e376e8dfe8db82aa0b15449389 
>   3rdparty/libprocess/src/help.cpp d358b93005506dad53aac815908cca59e6a53118 
>   3rdparty/libprocess/src/logging.cpp 
> db76abe08bc74c4d7444e112f32a5d11a236d229 
>   3rdparty/libprocess/src/metrics/metrics.cpp 
> 943ba63b01fd982185bc33679bba5cc3fcc086fc 
>   3rdparty/libprocess/src/process.cpp 
> 4afa30569b4d235637b49a624602e6b199c32e0e 
>   3rdparty/libprocess/src/tests/benchmarks.cpp 
> 97c81b8e61a75771e5bf7d46505cec4e0c0f404a 
>   3rdparty/libprocess/src/tests/decoder_tests.cpp 
> 6994fa96d33209f9a367b8c3bb09b0d050023fad 
>   3rdparty/libprocess/src/tests/http_tests.cpp 
> d0b9399d38fa284466a012a21080b1d9007af98b 
> 
> Diff: https://reviews.apache.org/r/38597/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Ben Mahler
> 
>

Reply via email to