> On Sept. 28, 2015, 8:43 p.m., Alex Clemmer wrote: > > Can you add this comment to the CMake build system as well? > > > > The file you need to change is here: > > https://github.com/apache/mesos/blob/master/3rdparty/CMakeLists.txt Should > > be line 40, above `PATCH_CMD`. > > Chris Chen wrote: > I don't see that file... > > Alex Clemmer wrote: > Hmm, I'm not 100% sure what you mean. Do you mean that you don't see it > in apache/master? This file was checked in yesterday (along with ~20 other > reviews relevant to the CMake stuff), perhaps it is the case that you haven't > pulled since then?
Lovely. My remote was set to the github copy. Reset origin to apache.org and I see it. Thx. - Chris ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38815/#review100860 ----------------------------------------------------------- On Sept. 28, 2015, 6:17 p.m., Chris Chen wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/38815/ > ----------------------------------------------------------- > > (Updated Sept. 28, 2015, 6:17 p.m.) > > > Review request for mesos. > > > Bugs: MESOS-3391 > https://issues.apache.org/jira/browse/MESOS-3391 > > > Repository: mesos > > > Description > ------- > > Problem: > The Zookeeeper C client does makes certain assertions about the ordering > of ping packets that the Java client does not. An alternate implementation > of the Zookeeper server would then break the C client while working > correctly with the Java client. > > Solution: > Port change from ZOOKEEPER-2253 to make C client handle pings similarly > to the Java client. > > Result: > C client and Java clients behave the same when dealing with an out-of-order > ping packet. > > > Diffs > ----- > > 3rdparty/Makefile.am 7c244a053044ae347f9505cb78a71a6636e26586 > 3rdparty/zookeeper-3.4.5.patch 3ca180d0c81f5de521ada7fb6c1c248a871ab2da > > Diff: https://reviews.apache.org/r/38815/diff/ > > > Testing > ------- > > Tested from upstream; Running mesos check suite currently. > > > Thanks, > > Chris Chen > >
