-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38817/#review100881
-----------------------------------------------------------



3rdparty/libprocess/src/tests/main.cpp (line 41)
<https://reviews.apache.org/r/38817/#comment158133>

    Here you probably want a signal string (strsignal ()) instead of a raw 
value.


- Cong Wang


On Sept. 28, 2015, 7:29 p.m., Ben Mahler wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38817/
> -----------------------------------------------------------
> 
> (Updated Sept. 28, 2015, 7:29 p.m.)
> 
> 
> Review request for mesos and Joris Van Remoortere.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> We're currently experiencing SIGPIPEs on the build, this will give us a stack 
> trace.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/src/tests/main.cpp 
> eec0c5f085dfed6dfeb3941528043dbd2eadcb59 
> 
> Diff: https://reviews.apache.org/r/38817/diff/
> 
> 
> Testing
> -------
> 
> Tested on CentOS and OS X:
> 
> On OS X, before:
> ```
> [ RUN      ] IOTest.Write
> make[5]: *** [check-local] Broken pipe: 13
> ```
> 
> After:
> ```
> [ RUN      ] IOTest.Write
> W0928 12:16:46.138653 190414848 main.cpp:52] RAW: Received signal SIGPIPE; 
> escalating to SIGABRT
> *** Aborted at 1443467806 (unix time) try "date -d @1443467806" if you are 
> using GNU date ***
> PC: @     0x7fff827b5c82 __kill
> *** SIGABRT (@0x7fff827b5c82) received by PID 88406 (TID 0x10b598000) stack 
> trace: ***
>     @     0x7fff8f155f1a _sigtramp
>     @     0x7fff650e327c (unknown)
>     @     0x7fff8f155f1a _sigtramp
>     @        0x10b5960b0 (unknown)
>     @     0x7fff8fd3eb6f std::__1::mutex::lock()
>     @        0x10a47d439 
> _ZZ11synchronizeINSt3__15mutexEE12SynchronizedIT_EPS3_ENKUlPS1_E_clES6_
>     @        0x10a47d418 
> _ZZ11synchronizeINSt3__15mutexEE12SynchronizedIT_EPS3_ENUlPS1_E_8__invokeES6_
>     @        0x10a47d269 Synchronized<>::Synchronized()
>     @        0x10a47d1ed Synchronized<>::Synchronized()
>     @        0x10a3df30c synchronize<>()
>     @        0x10a3f1b8e Gate::open()
>     @        0x10a3d3a07 process::ProcessManager::enqueue()
>     @        0x10a3cde0a process::ProcessBase::enqueue()
>     @        0x10a3cec43 process::SocketManager::exited()
>     @        0x10a3d5626 process::ProcessManager::cleanup()
>     @        0x10a3d442b process::ProcessManager::resume()
>     @        0x10a3dbe3c 
> process::ProcessManager::init_threads()::$_1::operator()()
>     @        0x10a3dbac2 
> _ZNSt3__114__thread_proxyINS_5tupleIJNS_6__bindIZN7process14ProcessManager12init_threadsEvE3$_1JNS_17reference_wrapperIKNS_6atomicIbEEEEEEEEEEEEPvSD_
>     @     0x7fff8885105a _pthread_body
>     @     0x7fff88850fd7 _pthread_start
>     @     0x7fff8884e3ed thread_start
> ```
> 
> 
> Thanks,
> 
> Ben Mahler
> 
>

Reply via email to