----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38468/#review100934 -----------------------------------------------------------
Ship it! This looks great! Thanks for the clarifications. I have a few suggestions, and if you're willing to integrate them, I'll go ahead and get this committed. Also, I notice your "Testing Done" section is blank. ;) Did you try rendering this patch to see if the lists/indents still render properly? I strongly recommend using https://github.com/mesosphere/mesos-website-container docs/submitting-a-patch.md (line 18) <https://reviews.apache.org/r/38468/#comment158202> Let's add a link to a query filtered to only Accepted issues. https://issues.apache.org/jira/browse/MESOS-1?jql=project%20%3D%20MESOS%20AND%20status%20%3D%20Accepted And mention the 'newbie' label, in case they want a good starter task. https://issues.apache.org/jira/browse/MESOS-1?jql=project%20%3D%20MESOS%20AND%20status%20%3D%20Accepted%20AND%20labels%20%3D%20newbie docs/submitting-a-patch.md (line 45) <https://reviews.apache.org/r/38468/#comment158203> Note that running mesos-tests does not recompile the tests, so you may want to first run `GTEST_FILTER="" make check` to recompile the tests without running any tests. docs/submitting-a-patch.md (line 64) <https://reviews.apache.org/r/38468/#comment158204> While we're at it, let's add a recommendation for "Testing Done": 11. Under "Testing Done", explain what new tests you have created, what tests were modified, and what procedures you went through to test your changes. - Adam B On Sept. 24, 2015, 2:29 p.m., Neil Conway wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/38468/ > ----------------------------------------------------------- > > (Updated Sept. 24, 2015, 2:29 p.m.) > > > Review request for mesos, Adam B, Benjamin Hindman, and Vinod Kone. > > > Repository: mesos > > > Description > ------- > > Added suggestion that new contributors seek to find a shepherd for their work > before their begin writing code. Made a few other improvements. > > > Diffs > ----- > > docs/reporting-a-bug.md 6c7f74719a8586f0608eb0f0f77d15c8d534321d > docs/submitting-a-patch.md 754a16f9b43630880f0f6c4a8e8e2f5e081b0a87 > > Diff: https://reviews.apache.org/r/38468/diff/ > > > Testing > ------- > > > Thanks, > > Neil Conway > >
