> On Sept. 29, 2015, 1:17 a.m., Timothy Chen wrote: > > src/slave/containerizer/docker.cpp, lines 926-928 > > <https://reviews.apache.org/r/38828/diff/1/?file=1086194#file1086194line926> > > > > Hey I think we should be doing the same behavior as MesosContainerizer > > since the executor behaves the same, and I think yes the extra close is not > > necessary.
Great, I'll get this committed then. - Ben ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38828/#review100913 ----------------------------------------------------------- On Sept. 29, 2015, 12:50 a.m., Chi Zhang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/38828/ > ----------------------------------------------------------- > > (Updated Sept. 29, 2015, 12:50 a.m.) > > > Review request for mesos, Ben Mahler and Timothy Chen. > > > Bugs: mesos-3519 > https://issues.apache.org/jira/browse/mesos-3519 > > > Repository: mesos > > > Description > ------- > > The slave will destroy executors that are not launched successfully, which > will > close all open file descriptors, thus the extra close is not needed. > > > Diffs > ----- > > src/slave/containerizer/docker.cpp efa37266368ee12fea9134b35ebc5047a2820f94 > > Diff: https://reviews.apache.org/r/38828/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Chi Zhang > >
