> On Sept. 29, 2015, 8:46 p.m., Ian Downes wrote:
> > src/tests/containerizer/fs_tests.cpp, line 203
> > <https://reviews.apache.org/r/38855/diff/2/?file=1087312#file1087312line203>
> >
> >     So the mount won't get cleaned up if the test asserts early?

We have a universal cleanup code here:
https://github.com/apache/mesos/blob/master/src/tests/environment.cpp#L458

So the mount will be cleaned up properly even if test asserts early.


- Jie


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38855/#review101009
-----------------------------------------------------------


On Sept. 29, 2015, 7:09 p.m., Jie Yu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38855/
> -----------------------------------------------------------
> 
> (Updated Sept. 29, 2015, 7:09 p.m.)
> 
> 
> Review request for mesos, Ian Downes, Timothy Chen, and Jiang Yan Xu.
> 
> 
> Bugs: MESOS-3539
>     https://issues.apache.org/jira/browse/MESOS-3539
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added support for getting shared and slave mount peer group ID.
> 
> 
> Diffs
> -----
> 
>   src/linux/fs.hpp f3aa0c2a385527eab5895f5d10c29e3d68e30a49 
>   src/linux/fs.cpp 8631d892ed6c132d6a9dc2031c2ca040623e9acc 
>   src/tests/containerizer/fs_tests.cpp 
> 34d3c41045373326fb6096031cd1daef0e7b203a 
> 
> Diff: https://reviews.apache.org/r/38855/diff/
> 
> 
> Testing
> -------
> 
> sudo make check
> 
> 
> Thanks,
> 
> Jie Yu
> 
>

Reply via email to