> On Sept. 25, 2015, 9:53 p.m., Vinod Kone wrote: > > src/linux/perf.cpp, line 792 > > <https://reviews.apache.org/r/37540/diff/7/?file=1077025#file1077025line792> > > > > so the semantics of this read() are a bit confusing. > > > > if the caller calls the read() back to back, they will get the same > > event if the first io::poll() is still running? but they will get a > > different event if io::poll() has finished before the 2nd read() is called?
That is correct. I want to ensure two different threads can get the same result when they read from the same perf event handler. - Cong ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37540/#review100656 ----------------------------------------------------------- On Sept. 18, 2015, 10:11 p.m., Cong Wang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/37540/ > ----------------------------------------------------------- > > (Updated Sept. 18, 2015, 10:11 p.m.) > > > Review request for mesos, Chi Zhang, Ian Downes, Jie Yu, and Vinod Kone. > > > Bugs: MESOS-2769 > https://issues.apache.org/jira/browse/MESOS-2769 > > > Repository: mesos > > > Description > ------- > > Abstract Linux kernel perf event API and provide API to collect schedule > events. > > > Diffs > ----- > > src/linux/perf.hpp d10968ca670eb516bae08385fd0ddde8e8ad83b5 > src/linux/perf.cpp f7035ddb2507a7646d88dd517d048018f695448a > src/tests/containerizer/perf_tests.cpp > ed5212ee31b8aa47339b8b8fab184bbdf85be82a > > Diff: https://reviews.apache.org/r/37540/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Cong Wang > >
