----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38452/#review101041 -----------------------------------------------------------
Ship it! Thanks for your patience! Just a couple of cleanups and I can get this committed for you. docs/mesos-c++-style-guide.md (lines 41 - 45) <https://reviews.apache.org/r/38452/#comment158344> To mirror the google style guide, can we place this before 'Naming'? docs/mesos-c++-style-guide.md (line 45) <https://reviews.apache.org/r/38452/#comment158345> Add the following trailing sentence: ``` ... you want to use. These should only be present at the top of the .cpp file. ``` - Ben Mahler On Sept. 29, 2015, 11:04 p.m., Guangya Liu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/38452/ > ----------------------------------------------------------- > > (Updated Sept. 29, 2015, 11:04 p.m.) > > > Review request for mesos and Ben Mahler. > > > Bugs: MESOS-3450 > https://issues.apache.org/jira/browse/MESOS-3450 > > > Repository: mesos > > > Description > ------- > > Updated C++ style guide for namespace usage > > > Diffs > ----- > > docs/mesos-c++-style-guide.md 570ea6873ffc2cc8ec190ec3aa81986e3f3cbc95 > > Diff: https://reviews.apache.org/r/38452/diff/ > > > Testing > ------- > > > Thanks, > > Guangya Liu > >
