-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38877/#review101077
-----------------------------------------------------------



src/slave/slave.hpp (line 169)
<https://reviews.apache.org/r/38877/#comment158394>

    Do you mind switch the first two parameters as following, this can 
highlight that this is an http call.
    
    void subscribe(
        HttpConnection http,
        const executor::Call::Subscribe& subscribe,
        Framework* framework,
        Executor* executor);



src/slave/slave.cpp (line 2385)
<https://reviews.apache.org/r/38877/#comment158395>

    What about using "Received subscription request for HTTP executor xxx" to 
keep consistent with scheduler log?



src/slave/slave.cpp (line 2387)
<https://reviews.apache.org/r/38877/#comment158398>

    How to handle the case if executor is in RECOVRING state? The logic is 
different for register and reregister with RECOVERING state.


- Guangya Liu


On 九月 30, 2015, 3:40 a.m., Anand Mazumdar wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38877/
> -----------------------------------------------------------
> 
> (Updated 九月 30, 2015, 3:40 a.m.)
> 
> 
> Review request for mesos, Ben Mahler, Isabel Jimenez, and Vinod Kone.
> 
> 
> Bugs: MESOS-3515
>     https://issues.apache.org/jira/browse/MESOS-3515
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This change adds the functionality for executors to `Subscribe` via the 
> `api/v1/executor` endpoint. It also stores a marker file as part of the 
> `Subscribe` call if framework `checkpointing` is enabled. This can then be 
> used by the agent when recovering to wait for reconnecting back with the 
> executor.
> 
> Since `Call::Update` is in progress as part of MESOS-3476. I have added a 
> `CHECK` if a executor tries to send a list of unacknowledged tasks as part of 
> the `Subscribe` call.
> 
> 
> Diffs
> -----
> 
>   src/slave/http.cpp f9cf7bbe81b7fe9637de9a8d66329c16a7e1a89b 
>   src/slave/slave.hpp 18be4f8188ad34ef4d0aa4b5eba241053d071476 
>   src/slave/slave.cpp d1c9977feeb30ad43586a4560eed155865d27a6c 
> 
> Diff: https://reviews.apache.org/r/38877/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Anand Mazumdar
> 
>

Reply via email to