> On Sept. 30, 2015, 5:41 a.m., Guangya Liu wrote:
> > src/slave/slave.cpp, line 2385
> > <https://reviews.apache.org/r/38877/diff/1/?file=1087521#file1087521line2385>
> >
> >     What about using "Received subscription request for HTTP executor xxx" 
> > to keep consistent with scheduler log?

Yeah the other `Agent` functions used the 'Got ...' lingo. Modified it now.


> On Sept. 30, 2015, 5:41 a.m., Guangya Liu wrote:
> > src/slave/slave.cpp, line 2387
> > <https://reviews.apache.org/r/38877/diff/1/?file=1087521#file1087521line2387>
> >
> >     How to handle the case if executor is in RECOVRING state? The logic is 
> > different for register and reregister with RECOVERING state.

I am assuming you were referring to the Agent state. We should never be in 
`state == RECOVERY` when we make a `Subscribe` call. 

This should already have been handled before here : 
https://github.com/apache/mesos/blob/master/src/slave/http.cpp#L218

We want the `CHECK` to fail if we ever land up here and the agent is still 
recovering !


- Anand


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38877/#review101077
-----------------------------------------------------------


On Sept. 30, 2015, 6:06 a.m., Anand Mazumdar wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38877/
> -----------------------------------------------------------
> 
> (Updated Sept. 30, 2015, 6:06 a.m.)
> 
> 
> Review request for mesos, Ben Mahler, Isabel Jimenez, and Vinod Kone.
> 
> 
> Bugs: MESOS-3515
>     https://issues.apache.org/jira/browse/MESOS-3515
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This change adds the functionality for executors to `Subscribe` via the 
> `api/v1/executor` endpoint. It also stores a marker file as part of the 
> `Subscribe` call if framework `checkpointing` is enabled. This can then be 
> used by the agent when recovering to wait for reconnecting back with the 
> executor.
> 
> Since `Call::Update` is in progress as part of MESOS-3476. I have added a 
> `CHECK` if a executor tries to send a list of unacknowledged tasks as part of 
> the `Subscribe` call.
> 
> 
> Diffs
> -----
> 
>   src/slave/http.cpp f9cf7bbe81b7fe9637de9a8d66329c16a7e1a89b 
>   src/slave/slave.hpp 18be4f8188ad34ef4d0aa4b5eba241053d071476 
>   src/slave/slave.cpp d1c9977feeb30ad43586a4560eed155865d27a6c 
> 
> Diff: https://reviews.apache.org/r/38877/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Anand Mazumdar
> 
>

Reply via email to