----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38919/#review101196 -----------------------------------------------------------
src/slave/containerizer/provisioner/docker/spec.cpp (line 42) <https://reviews.apache.org/r/38919/#comment158557> Fix spacing src/slave/containerizer/provisioner/docker/spec.cpp (line 48) <https://reviews.apache.org/r/38919/#comment158558> Fix spacing src/slave/containerizer/provisioner/docker/spec.cpp (line 52) <https://reviews.apache.org/r/38919/#comment158559> End with period. src/slave/containerizer/provisioner/docker/spec.cpp (line 57) <https://reviews.apache.org/r/38919/#comment158554> s/mush/must/g src/slave/containerizer/provisioner/docker/spec.cpp (line 68) <https://reviews.apache.org/r/38919/#comment158560> We should also verify that v1compat and blobsums length are equal. src/slave/containerizer/provisioner/docker/spec.cpp (line 79) <https://reviews.apache.org/r/38919/#comment158556> validation src/slave/containerizer/provisioner/docker/spec.cpp (line 83) <https://reviews.apache.org/r/38919/#comment158555> we need constants for all the magic numbers. - Timothy Chen On Oct. 1, 2015, 7:38 a.m., Gilbert Song wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/38919/ > ----------------------------------------------------------- > > (Updated Oct. 1, 2015, 7:38 a.m.) > > > Review request for mesos, Jojy Varghese and Timothy Chen. > > > Bugs: MESOS-3099 > https://issues.apache.org/jira/browse/MESOS-3099 > > > Repository: mesos > > > Description > ------- > > Validation of Docker Image Manifests > > > Diffs > ----- > > src/slave/containerizer/provisioner/docker/spec.hpp PRE-CREATION > src/slave/containerizer/provisioner/docker/spec.cpp PRE-CREATION > src/tests/containerizer/provisioner_docker_tests.cpp > d895eb9d0723e52cff8b21ef2deeaef1911d019c > > Diff: https://reviews.apache.org/r/38919/diff/ > > > Testing > ------- > > make check (Ubuntu14.04 + clang++-3.6) > > > Thanks, > > Gilbert Song > >
