> On Oct. 2, 2015, 3:01 p.m., Neil Conway wrote: > > I agree this is an improvement, but rather than doing this piecemeal, why > > not do it once across the whole codebase? > > > > Might also be worth adding to the style guide.
We have discussed that before and the agreement was not to do a sweep, but rather incrementally change when we touch appropriate files. See comments in https://reviews.apache.org/r/38161/ for reasoning for this patch. - Alexander ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38952/#review101323 ----------------------------------------------------------- On Oct. 2, 2015, 1:26 p.m., Alexander Rukletsov wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/38952/ > ----------------------------------------------------------- > > (Updated Oct. 2, 2015, 1:26 p.m.) > > > Review request for mesos and Ben Mahler. > > > Repository: mesos > > > Description > ------- > > See summary. > > > Diffs > ----- > > src/tests/fault_tolerance_tests.cpp > c97bc4691f9bac4a8677e6d2247be96ee9674b57 > > Diff: https://reviews.apache.org/r/38952/diff/ > > > Testing > ------- > > make check (Mac OS 10.10.4) > > > Thanks, > > Alexander Rukletsov > >
